Conversation
itazap
requested review from
ArthurZucker,
amyeroberts and
gante
and removed request for
ArthurZucker
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I'm surprised we need both git-lfs and pypi-kenlm for torch-speech - they seem unrelated to speech models (particularly git-lfs). Do you know which parts of the code were failing without these? |
| USER root | ||
| ARG REF=main | ||
| RUN apt-get update && apt-get install -y time git pkg-config make git-lfs | ||
| RUN apt-get update && apt-get install -y time git g++ pkg-config make git-lfs |
There was a problem hiding this comment.
do we need g++ for pypi-kenlm?
There was a problem hiding this comment.
yes, didn't work without. same as in torch-tf-light
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
LGTM!
(oopsie, I did a fire and forget, 100% forgot to double-check the result of the changes)
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
If we are installing torch-audio we might force install before to get cpu
| RUN apt-get update && apt-get install -y time git g++ pkg-config make git-lfs | ||
| ENV UV_PYTHON=/usr/local/bin/python | ||
| RUN pip install uv && uv venv && uv pip install --no-cache-dir -U pip setuptools GitPython | ||
| RUN uv pip install --no-cache-dir --upgrade 'torch' --index-url https://download.pytorch.org/whl/cpu |
There was a problem hiding this comment.
| RUN uv pip install --no-cache-dir --upgrade 'torch' --index-url https://download.pytorch.org/whl/cpu | |
| RUN uv pip install --no-cache-dir --upgrade 'torch' 'torchaudio' --index-url https://download.pytorch.org/whl/cpu | |
5 participants
follow up on #32389 to support torch-speech, we need to install
git-lfsandpypi-kenlmcurrently causing failures on docker image like here
CC @ArthurZucker @gante